Context Navigation

← Previous Ticket
Next Ticket →

Ticket #11 (closed defect: fixed)

Opened 3 years ago

Last modified 21 months ago

ComposedObject::def_traits installs trait methods in ComposedObject instead of the calling class

Reported by:	ged	Owned by:	ged
Priority:	normal	Milestone:	ActualityEpic
Component:	GameWorld	Version:	1.0
Severity:	normal	Keywords:	traits composed object character
Cc:

Description

I noticed that the trait methods defined in the character actually show up in ComposedObject?, which has the end result that every class derived from ComposedObject? shares its traits with every other one. This, of course, is bad.

I've written a little test script (in source:trunk/experiments/where-do-traits-inhere.rb) whose output is:

[pts/ttyp4] 63/538 {0}$ ruby experiments/where-do-traits-inhere.rb
Trying FaerieMUD::Character.instance_methods(false) & traits...
---------------------------------------------------------------------------
[]
---------------------------------------------------------------------------

Trying FaerieMUD::ComposedObject.instance_methods(false) & traits...
---------------------------------------------------------------------------
["strength", "magistry", "grace", "dexterity"]
---------------------------------------------------------------------------

When this is fixed, they should show up in the top section instead of the bottom one.

Change History

Changed 3 years ago by ged

status changed from new to assigned

Successfully expressed the problem as tests:

dsl081-108-087 pts/ttyp5 [~/source/ruby/FaerieMUD]
2/502 {0}$ ./test.rb composed
1 patterns given on the command line
Required 1 files.
[/Users/ged/source/ruby/FaerieMUD/tests/composedobject.tests.rb]
Loaded suite FaerieMUD
Started
....FFFFF
Finished in 0.615531 seconds.

  1) Failure:
test_40_DefineUnaryTraits(FaerieMUD::ComposedObjectTestCase)
    [/Users/ged/source/ruby/FaerieMUD/tests/composedobject.tests.rb:316:in `test_40_DefineUnaryTraits'
     /Users/ged/source/ruby/FaerieMUD/tests/lib/fmtestcase.rb:195:in `run']:
Trait method #trait1 should inhere in the subclass.
<false> is not true.

  2) Failure:
test_41_DefineBinaryTraits(FaerieMUD::ComposedObjectTestCase)
    [/Users/ged/source/ruby/FaerieMUD/tests/composedobject.tests.rb:368:in `test_41_DefineBinaryTraits'
     /Users/ged/source/ruby/FaerieMUD/tests/lib/fmtestcase.rb:195:in `run']:
Trait method #trait1_2 should inhere in the subclass.
<false> is not true.

  3) Failure:
test_42_DefineTrinaryTraits(FaerieMUD::ComposedObjectTestCase)
    [/Users/ged/source/ruby/FaerieMUD/tests/composedobject.tests.rb:426:in `test_42_DefineTrinaryTraits'
     /Users/ged/source/ruby/FaerieMUD/tests/lib/fmtestcase.rb:195:in `run']:
Trait method #trait1_2_3 should inhere in the subclass.
<false> is not true.

  4) Failure:
test_50_StatisticAspectMethods(FaerieMUD::ComposedObjectTestCase)
    [/Users/ged/source/ruby/FaerieMUD/tests/composedobject.tests.rb:470:in `test_50_StatisticAspectMethods'
     /Users/ged/source/ruby/FaerieMUD/tests/composedobject.tests.rb:469:in `each'
     /Users/ged/source/ruby/FaerieMUD/tests/composedobject.tests.rb:469:in `test_50_StatisticAspectMethods'
     /Users/ged/source/ruby/FaerieMUD/tests/lib/fmtestcase.rb:195:in `run']:
<nil>
of type <NilClass>
expected to respond_to?<:devel_aspect0>.

  5) Failure:
test_60_Duplication(FaerieMUD::ComposedObjectTestCase)
    [/Users/ged/source/ruby/FaerieMUD/tests/composedobject.tests.rb:483:in `test_60_Duplication'
     /Users/ged/source/ruby/FaerieMUD/tests/lib/fmtestcase.rb:195:in `run']:
Exception raised:
Class: <TypeError>
Message: <"can't clone NilClass">
---Backtrace---
/Users/ged/source/ruby/FaerieMUD/tests/composedobject.tests.rb:483:in `clone'
/Users/ged/source/ruby/FaerieMUD/tests/composedobject.tests.rb:483:in `test_60_Duplication'
/Users/ged/source/ruby/FaerieMUD/tests/composedobject.tests.rb:483:in `assert_nothing_raised'
/Users/ged/source/ruby/FaerieMUD/tests/composedobject.tests.rb:483:in `test_60_Duplication'
/Users/ged/source/ruby/FaerieMUD/tests/lib/fmtestcase.rb:195:in `run'
---------------

9 tests, 73 assertions, 5 failures, 0 errors

Changed 23 months ago by haoracks